Fix truncated href tags #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A little kludgy, but it'll blend right in! |
test/issues/338-test.js
Outdated
|
|
||
| table.push([{ content: 'looooooooooooong', href }]); | ||
|
|
||
| expect(table.toString().includes('\x1B]8;;\x07')).toEqual(true); |
There was a problem hiding this comment.
I wonder if it'd be better to test the full output here. Concatenating the link closure incorrectly would still lead to a passing test.
There was a problem hiding this comment.
I didn't do this initially because the string-literal table doesn't look as nice as the ones in the other issue tests. But I made the change and it seems fine.
|
Okay to merge (and publish)? |
Looks good. Fell off my radar. I'll get a new release out shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #338
This is a bad solution, and I understand if you'd prefer not to merge it.