Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds-favicon #2089

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adds-favicon #2089

wants to merge 1 commit into from

Conversation

mahsakhorshiddoust
Copy link

No description provided.

@leaofelipe
Copy link
Member

Hi @mahsakhorshiddoust! Thank you for contributing!
I have a few subjects to discuss in this PR:

  1. Can you fill in the description with the motivation for it? Adding more info?
  2. If you want to change the Favicon, the icon you suggest doesn't have a proportional width/height size for a favicon.
  3. Do you want to change the local testing page? or did your PR is for Clappr Public page?

Thank you!

@ajaysonere
Copy link

ajaysonere commented Oct 11, 2023 •
edited

@leaofelipe can i give it try ?

@jhonatangcavalcanti jhonatangcavalcanti deleted the branch clappr:main May 6, 2024 13:50
@jhonatangcavalcanti jhonatangcavalcanti changed the base branch from dev to main May 6, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mahsakhorshiddoust @leaofelipe @ajaysonere @jhonatangcavalcanti