Fun for next release #196
Draft
Fun for next release #196
+360,375
−71,819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanm
force-pushed
the
pr/fun-next-release
branch
2 times, most recently
from
2dc554d
to
2a2f7ab
Compare
Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
GH started to complain that we need to define either a GH issue or a pull-request when searching using the API to search for issues. Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
If we want to executed PrintReleaseNotesForWriter multiple times it won't be possible since this function deletes the internal state of ChangeLog. Thus, we should do an internal DeepCopy to prevent data deletion. Signed-off-by: André Martins <[email protected]>
Instead of using a common filename we should use a dedicated file name for each owner, project, version tuple. Signed-off-by: André Martins <[email protected]>
The way we are going to manage projects is being redesigned thus we can remove this piece of code. Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
When generating the CHANGELOG some PRs might have been deleted by GitHub. To prevent the release changelog generator from failing we should ignore the PRs that are not found and also inform the user about such PRs. Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
With groups of steps the release manager can perform the release process on different stages. Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
Signed-off-by: André Martins <[email protected]>
aanm
force-pushed
the
pr/fun-next-release
branch
from
2739272
to
54ef1b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not run code without removing TODOs