Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link: add Info() method to all link types #1435

Merged
merged 1 commit into from
May 24, 2024

Conversation

rgo3
Copy link
Contributor

@rgo3 rgo3 commented Apr 15, 2024

This PR pulls out retrieving linktype-specific metadata from RawLink.Info(). This will reduce the amount of syscalls when calling RawLink.Info() directly. If needed the inktype-specific metadata can now be retrieved through linktype-specific Info() methods.

@rgo3 rgo3 force-pushed the add-info-implementations branch from 0226417 to 01982d5 Compare May 16, 2024 11:34
link/netkit.go Outdated Show resolved Hide resolved
link/tcx.go Outdated Show resolved Hide resolved
@rgo3 rgo3 force-pushed the add-info-implementations branch from 01982d5 to 53dffd2 Compare May 23, 2024 12:16
link/link.go Show resolved Hide resolved
link/iter.go Outdated Show resolved Hide resolved
link/link.go Show resolved Hide resolved
link/xdp.go Show resolved Hide resolved
@rgo3 rgo3 force-pushed the add-info-implementations branch from 53dffd2 to f508e58 Compare May 23, 2024 15:51
@rgo3 rgo3 marked this pull request as ready for review May 23, 2024 16:21
@rgo3 rgo3 requested a review from mmat11 as a code owner May 23, 2024 16:21
Copy link
Collaborator

@lmb lmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@lmb lmb merged commit f82b29b into cilium:main May 24, 2024
17 checks passed
@lmb
Copy link
Collaborator

lmb commented May 24, 2024

Thanks as always :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants