Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update list of SIGs #32477

Merged
merged 1 commit into from May 13, 2024
Merged

update list of SIGs #32477

merged 1 commit into from May 13, 2024

Conversation

katiestruthers
Copy link
Contributor

@katiestruthers katiestruthers commented May 10, 2024 •
edited

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Update the list of SIGs to reflect all sig- channels found in Cilium Slack, as well as some minor styling changes. This list needs to be updated to further streamline the process of getting Cilium Feature Proposals approved.

@katiestruthers
update list of SIGs
3d2b03a 
Signed-off-by: Katie Struthers <[email protected]>
@katiestruthers katiestruthers requested a review from a team as a code owner May 10, 2024 22:10
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 10, 2024
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label May 10, 2024
@katiestruthers
Copy link
Contributor Author

katiestruthers commented May 10, 2024 •
edited

Please add the following label: area/documentation

@katiestruthers katiestruthers mentioned this pull request May 13, 2024
Open
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels May 13, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 13, 2024
qmonnet
qmonnet approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@qmonnet
Copy link
Member

qmonnet commented May 13, 2024

/test

@qmonnet qmonnet added this pull request to the merge queue May 13, 2024
Merged via the queue into cilium:main with commit 14f0780 May 13, 2024
63 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@katiestruthers @qmonnet