Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpv2: Exporting peer, route and route-policy states of BGPv2 via CLI. #32474

Merged
merged 2 commits into from May 15, 2024

Conversation

harsimran-pabla
Copy link
Contributor

@harsimran-pabla harsimran-pabla commented May 10, 2024

This change exposes various BGP states from BGPInstances ( BGPv2 implementation ) into existing CLIs. It adds a thin switch layer in BGP manager to get v1 or v2 states.

There is no change to CLI or http API and how users interact with Cilium to get BGP state.

Please see individual commits for peers, routes and route-policies changes.

BGP:  Exporting peers, routes and route-policy states of BGPv2 via CLI. 

@harsimran-pabla harsimran-pabla added release-note/misc This PR makes changes that have no direct user impact. area/bgp labels May 10, 2024
@harsimran-pabla harsimran-pabla requested a review from a team as a code owner May 10, 2024 18:56
@harsimran-pabla
Copy link
Contributor Author

/test

@harsimran-pabla harsimran-pabla force-pushed the hpabla/bgp/v2/state branch 2 times, most recently from 0a2a56f to 0d79a4c Compare May 13, 2024 14:59
@harsimran-pabla
Copy link
Contributor Author

/test

@harsimran-pabla
Copy link
Contributor Author

/test

Moving ConfigMode of bgp controller into its own package. It is done so
ConfigMode can be used in various other sub-packages without causing
circular dependency.

Signed-off-by: harsimran pabla <[email protected]>
Add ConfigMode hook in BGPRouterManager, which can be used when getting
various states like peers, routes, or route-policies.

Adding toggle layer to fetch state from BGPv1 vs BGPv2 gobgp instances
based on config mode.

Signed-off-by: harsimran pabla <[email protected]>
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

@harsimran-pabla
Copy link
Contributor Author

/test

@harsimran-pabla
Copy link
Contributor Author

harsimran-pabla commented May 14, 2024

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 14, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue May 15, 2024
Merged via the queue into cilium:main with commit 9099d8e May 15, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bgp ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants