devices: Use slog instead of logrus #32469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joamaki
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
With the conversion to slog we no longer have WithError() and
thus need a logfield for errors.
Before:
var log logrus.FieldLogger
var err error
log.WithError(err).Error("oops")
After:
var log *slog.Logger
var err error
log.Error("oops", logfields.Error, err)
Signed-off-by: Jussi Maki <[email protected]>
Use the slog.Logger in DevicesController for logging. Signed-off-by: Jussi Maki <[email protected]>
joamaki
force-pushed
the
pr/joamaki/devices-controller-slog
branch
from
611593b
to
da32bd8
Compare
|
/test |
dylandreimerink
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's get the ball rolling on the logrus=>slog migration!
First commit adds "logfields.Error" to use with e.g.
log.Error("oops", logfields.Error, err).Second commit refactors DevicesController to use slog instead of logrus.