Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add job name validation #32462

Merged
merged 1 commit into from May 13, 2024

Conversation

brlbil
Copy link
Contributor

@brlbil brlbil commented May 10, 2024

This PR adds validation for commit_status_start job. This job is used in workflows that is triggered by Ariane to set the run status to pending. Ariane is going to depend on this job being existed and its name is "Commit Status Start". So we are adding this check to make sure.
Also, the trigger syntax of link-build-commits.yaml is changed because yq is throwing an error.

This commit adds validation for `commit_status_start` job.
This job is used in workflows that is triggered by Ariane to set the run status to pending.
Ariane is going to depend on this job being existed and its name is "Commit Status Start".
Also, the trigger syntax of `link-build-commits.yaml` is changed because `yq` is throwing an error.

Signed-off-by: Birol Bilgin <[email protected]>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 10, 2024
@brlbil brlbil added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels May 10, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 10, 2024
@brlbil brlbil added needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels May 10, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.15.5 May 10, 2024
@brlbil brlbil removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels May 10, 2024
@brlbil
Copy link
Contributor Author

brlbil commented May 10, 2024

/test

@brlbil brlbil marked this pull request as ready for review May 10, 2024 12:42
@brlbil brlbil requested review from a team as code owners May 10, 2024 12:42
@brlbil brlbil requested a review from christarazi May 10, 2024 12:42
@brlbil
Copy link
Contributor Author

brlbil commented May 10, 2024

/test

@brlbil
Copy link
Contributor Author

brlbil commented May 10, 2024

Conformance Multi Pool IPAM (ci-multi-pool) test is not triggered for some reason.

@brlbil
Copy link
Contributor Author

brlbil commented May 10, 2024

/test

1 similar comment
@brlbil
Copy link
Contributor Author

brlbil commented May 10, 2024

/test

@brlbil
Copy link
Contributor Author

brlbil commented May 10, 2024

Sorry for the noise I am trying to find the issue with the not-triggered workflow.

@brlbil
Copy link
Contributor Author

brlbil commented May 10, 2024

/test

@nebril nebril added this to Needs backport from main in 1.15.6 May 10, 2024
@nebril nebril removed this from Needs backport from main in 1.15.5 May 10, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 11, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue May 13, 2024
Merged via the queue into main with commit 3f5e735 May 13, 2024
67 checks passed
@julianwiedmann julianwiedmann deleted the pr/brlbil/add_commit_status_start_validation branch May 13, 2024 07:35
@jibi jibi mentioned this pull request May 13, 2024
5 tasks
@jibi jibi added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels May 13, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
1.15.6
Needs backport from main
Development

Successfully merging this pull request may close these issues.

None yet

5 participants