Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images/cilium: Move Envoy reference away from builder and runtime #32452

Merged
merged 1 commit into from May 13, 2024

Conversation

jrajahalme
Copy link
Member

@jrajahalme jrajahalme commented May 10, 2024

Having the envoy reference next to the builder and runtime references causes git context conflicts for PRs whenever either of them change in main. Keep them separate to avoid unnecessary merge conflicts.

Fixes: #29638

Having the envoy reference next to the builder and runtime references
causes git context conflicts for PRs whenever either of them change in
main. Keep them separate to avoid unnecessary merge conflicts.

Signed-off-by: Jarno Rajahalme <[email protected]>
@jrajahalme jrajahalme added the release-note/misc This PR makes changes that have no direct user impact. label May 10, 2024
@jrajahalme jrajahalme requested a review from a team as a code owner May 10, 2024 05:50
@jrajahalme jrajahalme requested a review from borkmann May 10, 2024 05:50
@jrajahalme
Copy link
Member Author

/test

@joestringer joestringer removed the request for review from borkmann May 13, 2024 18:20
@joestringer joestringer added this pull request to the merge queue May 13, 2024
Merged via the queue into cilium:main with commit 6e7dbb8 May 13, 2024
65 of 66 checks passed
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants