connectivity test: Fix flow validation for nodeport service tests #2103
+31
β40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
NodeportService.Address()
IPv6 check and generalizeNodeportService
by using in[]corev1.NodeAddress
instead of*corev1.Node
so that test cases can customize the addresses to be used. UseNodeportService
to simplify special casing for nodeport tests.Pass the IP family of the current node address to
t.NewAction()
, so that the address of the correct family is used in flow validation. This fixes the bug where IPv4 address is being used to validate an IPv6 flow like below: