Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLN] Improve JS client async errors tests #2135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CLN] Improve JS client async errors tests #2135

wants to merge 1 commit into from

Commits on May 4, 2024

  1. [CLN] Improve JS client error testing 

    Use the jest standard Jest way for testing for rejected promises:
`await expect(...).rejects.throw(new Error("expected message"));`.

Before, some of the tests were not failing if an error is thrown -> the tests did not really test what was expected. Skipped one such test ("client.get should error on empty embedding"). I will fix it in a next PR.
    @ibratoev
    ibratoev committed May 4, 2024
    Configuration menu
    Copy the full SHA
    9c744cf View commit details
    Browse the repository at this point in the history