-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BLD] Build Dockerfile on Windows #2130
Open
codetheweb
wants to merge
40
commits into
main
Choose a base branch
from
fix-dockerfile-windows
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+66
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas |
codetheweb
force-pushed
the
fix-dockerfile-windows
branch
from
May 3, 2024 22:50
718e79a
to
a621f07
Compare
codetheweb
force-pushed
the
fix-dockerfile-windows
branch
from
May 3, 2024 23:07
a621f07
to
fdd6379
Compare
codetheweb
force-pushed
the
fix-dockerfile-windows
branch
from
May 6, 2024 15:17
0b08cf8
to
23e2edf
Compare
(actually tested on Windows)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Windows-specific Dockerfile to enable running integration tests on Windows. Although we specified Windows as a test platform prior to the CI refactor a few weeks ago, all Windows tests were silently failing.
This PR enables a subset of integration tests, we can easily enable the rest in the future.
(I believe the commit history is scuffed because I squashed a related PR... looks like it's time for me to try Graphite)