[ENH] Add LogPosition and CollectionVersion to Segment database model #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @Ishiihara and the rest of your teammates on |
1 task
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Ishiihara
force-pushed
the
liquan_cache_invalidation_schema
branch
from
e3a5883
to
52dec21
Compare
Ishiihara
force-pushed
the
liquan_cache_invalidation_proto
branch
from
65206f1
to
46b770f
Compare
Ishiihara
force-pushed
the
liquan_cache_invalidation_schema
branch
from
52dec21
to
2ff4cc4
Compare
HammadB
reviewed
Apr 27, 2024
| CreatedAt time.Time `gorm:"created_at;type:timestamp;not null;default:current_timestamp"` | ||
| UpdatedAt time.Time `gorm:"updated_at;type:timestamp;not null;default:current_timestamp"` | ||
| FilePaths map[string][]string `gorm:"file_paths;serializer:json;default:'{}'"` | ||
| LogPosition int64 `gorm:"log_position;default:0"` |
There was a problem hiding this comment.
I think we should think a little carefully about this change and its implications. Do we want to implictly preserve the contract that this advances in lockstep with collections log position?
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?