[BUG]: WAL replay warnings suppression #1763
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
tazarov
force-pushed
the
bugfix/wal-replay-ignore-warnings
branch
from
fa94bdb
to
71e7619
Compare
atroyn
requested changes
Mar 2, 2024
|
@atroyn, I've added a colab that reproduces the problem. The gist is that we emit all entries from the WAL up to the index' MAX seqId, if there are duplicate entries (e.g. an item was added/removed multiple times) the respective index reports the duplicates as warnings. |
|
Similar issue was reported by MemGPT - https://discord.com/channels/1073293645303795742/1205288940488359998 |
tazarov
commented
Mar 2, 2024
| @@ -288,7 +288,9 @@ def _backfill(self, subscription: Subscription) -> None: | |||
| .where(t.topic == ParameterValue(subscription.topic_name)) | |||
| .where(t.seq_id > ParameterValue(subscription.start)) | |||
| .where(t.seq_id <= ParameterValue(subscription.end)) | |||
| .select(t.seq_id, t.operation, t.id, t.vector, t.encoding, t.metadata) | |||
| .select( | |||
| t.seq_id, t.operation, t.id, t.vector, t.encoding, t.metadata, t.topic | |||
There was a problem hiding this comment.
I don't think topic is needed here. Perhaps wrongfully added during testing/experimentation
|
This is potentially made redundant by #2062 |
|
Close in favor of #2062 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #1733
Description of changes
Summarize the changes made by this PR.
EmbeddingRecordflag (wal_replay) to suppress warnings in sqlite and local hnsw indicesTest plan
How are these changes tested?
pytestfor python,yarn testfor jsDocumentation Changes
N/A
Colab to reproduce the issue in 0.4.23 (and prior) - https://colab.research.google.com/drive/1CtN0qGoMZoVfwQBnJE1MloLvvdv5KouE?usp=sharing