[FileCache#Find] N to 1 calls for file matching #14351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafyddcrosby
force-pushed
the
filecache_find_dirglob
branch
from
76490a7
to
0acda49
Compare
dafyddcrosby
changed the title
dafyddcrosby
force-pushed
the
filecache_find_dirglob
branch
2 times, most recently
from
4093aac
to
d65551e
Compare
dafyddcrosby
force-pushed
the
filecache_find_dirglob
branch
2 times, most recently
from
b421935
to
9a2c309
Compare
dafyddcrosby
changed the title
dafyddcrosby
force-pushed
the
filecache_find_dirglob
branch
3 times, most recently
from
7297be6
to
f48c75d
Compare
Signed-off-by: David Crosby <[email protected]>
dafyddcrosby
force-pushed
the
filecache_find_dirglob
branch
from
f48c75d
to
5701d39
Compare
jaymzh
approved these changes
May 21, 2024
tpowell-progress
added
the
Status: Waiting on Contributor
Signed-off-by: David Crosby <[email protected]>
Instead of holding the reference to files the whole loop, use until and take the head from the array Signed-off-by: David Crosby <[email protected]>
Signed-off-by: David Crosby <[email protected]>
The regular expression's capture is changed so that instead of capturing the tail of the file string (ie cache path excluded), we capture the cache path instead so that we can use delete_prefix calls to mutate the strings directly, saving on allocations Signed-off-by: David Crosby <[email protected]>
dafyddcrosby
force-pushed
the
filecache_find_dirglob
branch
from
5701d39
to
7f821bb
Compare
|
tpowell-progress
added
Status: Waiting for Build Fix
and removed
Status: Waiting on Contributor
tpowell-progress
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves pre-computable values from the inner loop of
#findto outside of the loop.Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.