Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Added link to the video instructions on beginning development page #14865

Merged
merged 1 commit into from May 12, 2024

Conversation

SteLeo1602
Copy link
Contributor

@SteLeo1602 SteLeo1602 commented May 7, 2024

Added link to the playlist of my video tutorials
image

@romani
Copy link
Member

romani commented May 7, 2024

Please apply patch https://dev.azure.com/romanivanovjr/romanivanovjr/_build/results?buildId=21348&view=logs&j=6a833393-c551-5000-0916-5000fd3b86e7&t=bdbbd129-77f0-5d73-ce7d-db58d34c8358 , to let CI be green.
This is unfortunate side effect of spell checker execution over URLs, we need to add all such "words" to whitelist file.

Patch command is copy paste able to terminal.

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok to merge is CI is green

@romani
Copy link
Member

romani commented May 8, 2024

GitHub, generate website

@romani romani assigned nrmancuso and unassigned romani May 8, 2024
@romani romani requested review from nrmancuso and rnveach May 8, 2024 01:37
Copy link
Member

@nrmancuso nrmancuso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SteLeo1602. My only possible item for improvement would to actually show how to fork the repo, but it is understandable to not do this with open PRs :)

@nrmancuso nrmancuso assigned rnveach and unassigned nrmancuso May 8, 2024
@romani
Copy link
Member

romani commented May 8, 2024

This is initial base set of videos, there will be more, on how to debug, on .... . They will be added to this play list.
@SteLeo1602 , made good setup on how to do such videos, I hope he will share knowledge on more items that beginner need so much, and maintainers thinks it is too basic to even mention.

@romani
Copy link
Member

romani commented May 8, 2024

GitHub, generate website

@nrmancuso
Copy link
Member

This is initial base set of videos, there will be more, on how to debug, on .... . They will be added to this play list.

@romani If this is in response to my comment at #14865 (comment), you are missing the point. If you watch the video, you will notice that the actual steps for forking the repository are glossed over because it has already been forked. Ideally, @SteLeo1602 would have deleted their fork for this video so that viewers could see the entire process.

src/xdocs/beginning_development.xml Outdated Show resolved Hide resolved
src/xdocs/beginning_development.xml Outdated Show resolved Hide resolved
src/xdocs/beginning_development.xml Outdated Show resolved Hide resolved
src/xdocs/beginning_development.xml Outdated Show resolved Hide resolved
@SteLeo1602 SteLeo1602 closed this May 11, 2024
@SteLeo1602 SteLeo1602 reopened this May 11, 2024
@SteLeo1602
Copy link
Contributor Author

SteLeo1602 commented May 11, 2024

Thanks @SteLeo1602. My only possible item for improvement would to actually show how to fork the repo, but it is understandable to not do this with open PRs :)

I was going to show them the process of fork creation, but indeed decided to leave it in favor of existing pull requests. What I can try to do is to put the image instructions for creating a fork over the moment of that existing video to display my thoughts.

@SteLeo1602 SteLeo1602 force-pushed the tutorialDocAdd branch 2 times, most recently from 1bb263d to 40398ac Compare May 11, 2024 07:32
@SteLeo1602
Copy link
Contributor Author

GitHub, generate website

@rnveach rnveach merged commit a7ca081 into checkstyle:master May 12, 2024
114 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants