Replace recursion by loop to parse huge files #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to parse huge bibtex files (e.g. one of the cryptobib files) recursion in the
entries
parser atsrc/parser.rs:368:51
exhausts the stack and causes an overflow. Try using e.g. backtrace_on_stack_overflow to verify this.Example code:
Using a loop instead resolves this issue (see diff). This also removes the need for the
O(n)
insert operation because the entries are parsed in the original order instead of reversed, so push can be used.