Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Save and continue on all pages (Phase 1) #552

Merged
merged 12 commits into from
Jun 4, 2024

Conversation

meissadia
Copy link
Collaborator

@meissadia meissadia commented May 21, 2024

Close #549

Affected pages: Upload, Errors, Warnings

Changes

  • Save and continue always enabled but triggers error display when step is incomplete.
    • Displayed with secondary styling when step is not complete
    • Displayed with primary styling when step is complete
  • Warnings - Displays error state + message in Verification well when appropriate

How to test this PR

  1. See screenshots

Screenshots

Upload

Upload__Save-always-enabled.mov

Errors & Warnings

Errors-Warnings__Save-always-enabled.mov

@meissadia meissadia mentioned this pull request May 23, 2024
7 tasks
@billhimmelsbach
Copy link
Contributor

Heyo @meissadia, can we lift this out of draft?

@meissadia meissadia marked this pull request as ready for review May 29, 2024 16:32
@billhimmelsbach
Copy link
Contributor

I haven't forgotten about this PR, but I'm wary about adding it until the content stuff is done. Can I save it for last?

Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a lot of little design questions about this one...

This won't work for Point of Contact right?

For the error and warning pages, when we might have a dozen or more error categories, are we going to scroll allll the way to the top for this error when this page might be pretty huge? Seems like for these save and continue errors, we'd want the error near the buttons?

We got some pre-clearance feedback on this about maybe the styling be a little confusing, so I might also suggest just making the button look like it's in a disabled state.

This one isn't content related, so it can wait a bit for some Natalia feedback on Tuesday.

Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to approve and merge this one, then iterate. So here's the 👍

@meissadia meissadia merged commit d28bdb9 into main Jun 4, 2024
3 checks passed
@meissadia meissadia deleted the 532_save-and-continue__phase-1 branch June 4, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Save and continue on all pages -- Phase 1
2 participants