Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Save and continue on all pages -- Phase 1 #549

Closed
1 task
meissadia opened this issue May 20, 2024 · 0 comments · Fixed by #552
Closed
1 task

Enable Save and continue on all pages -- Phase 1 #549

meissadia opened this issue May 20, 2024 · 0 comments · Fixed by #552
Assignees
@meissadia
Labels
mvp Need to be completed before MVP

Comments

@meissadia
Copy link
Collaborator

meissadia commented May 20, 2024 •
edited

Phase 1

Implement this on pages: Upload, Errors, Warnings
@meissadia meissadia self-assigned this May 20, 2024
@meissadia meissadia added the mvp Need to be completed before MVP label May 20, 2024
@meissadia meissadia changed the title Enable Save and continue on all pages (Phase 1) (Phase 1) Enable Save and continue on all pages May 20, 2024
This was referenced May 20, 2024
Open
Open
Merged
Closed
@meissadia meissadia changed the title (Phase 1) Enable Save and continue on all pages Enable Save and continue on all pages (Phase 1) May 23, 2024
@meissadia meissadia changed the title Enable Save and continue on all pages (Phase 1) Enable Save and continue on all pages -- Phase 1 May 23, 2024
meissadia added a commit that referenced this issue Jun 4, 2024
@meissadia
Enable Save and continue on all pages (Phase 1) (#552)
d28bdb9 
Close #549 

Affected pages: Upload, Errors, Warnings

## Changes

- `Save and continue` always enabled but triggers error display when
step is incomplete.
  - Displayed with `secondary` styling when step is not complete
  - Displayed with `primary` styling when step is complete
- Warnings - Displays error state + message in Verification well when
appropriate

## How to test this PR

1. See screenshots

## Screenshots
### Upload

https://github.com/cfpb/sbl-frontend/assets/2592907/838046e8-989c-4a17-951a-f4b1ab60f393

### Errors & Warnings

https://github.com/cfpb/sbl-frontend/assets/2592907/716c748f-b6e0-4b73-bea2-91a3f17611f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meissadia meissadia

Labels
mvp Need to be completed before MVP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable Save and continue on all pages (Phase 1) cfpb/sbl-frontend
1 participant
@meissadia