-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qa/cephfs: block buggy tests in test_admin.py #57496
qa/cephfs: block buggy tests in test_admin.py #57496
Conversation
Had a conversation with Venky about this, it's good to do a quick QA for this PR so that it can be merge ASAP to make sure test_admin does fine in QA runs - https://pulpito.ceph.com/rishabh-2024-05-16_07:25:57-fs:functional-main-testing-default-smithi/ |
1197f8a
to
ca86a59
Compare
This PR is under test in https://tracker.ceph.com/issues/66065. |
* refs/pull/57496/head: qa/cephfs: block buggy tests in test_admin.py
ca86a59
to
d0ba509
Compare
This PR is under test in https://tracker.ceph.com/issues/66067. |
* refs/pull/57496/head: qa/cephfs: block buggy tests in test_admin.py
d0ba509
to
f0342d4
Compare
* refs/pull/57496/head: qa/cephfs: block buggy tests in test_admin.py
f0342d4
to
2b60c8b
Compare
Current approach is better than previous because we don't need to import |
* refs/pull/57496/head: qa/cephfs: block buggy tests in test_admin.py
* refs/pull/57496/head: qa/cephfs: block buggy tests in test_admin.py
* refs/pull/57496/head: qa/cephfs: block buggy tests in test_admin.py
jenkins test make check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Please link the new trackers for the buggy tests.
Block test_idem_unaffected_root_squash temporarily and test_multifs_single_path_rootsquash. This test fails due to a known bug. Block it temporarily so that test_admin.py can run fully and PRs under QA can be tested fully. Otherwise, this test fails and that halts test_admin.py, which leaves the PR partially untested. This failure is then seen as an unrelated failure which lets the buggy code get merged. This has happened recently. Signed-off-by: Rishabh Dave <[email protected]>
2b60c8b
to
b7d0770
Compare
* refs/pull/57496/head: qa/cephfs: block buggy tests in test_admin.py Reviewed-by: Venky Shankar <[email protected]> Reviewed-by: Patrick Donnelly <[email protected]>
https://jenkins.ceph.com/job/ceph-pull-requests/135177/ - "slave crashed", looks like transient infra issue |
jenkins test make check |
QA run was successful - https://pulpito.ceph.com/rishabh-2024-05-17_04:50:48-fs:functional-main-testing-default-smithi/. |
This test fails due to a known bug. Block it temporarily so that
test_admin.py can run fully and PRs under QA can be tested fully.
Otherwise, this test fails and that halts test_admin.py, which leaves
the PR partially untested.
This failure is then seen as an unrelated failure which lets the buggy
code get merged. This has happened recently.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
x
between the brackets:[x]
. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e