-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hwh v17.2.6 #57468
Closed
Closed
Hwh v17.2.6 #57468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, it could remain in the list and cephadm could think there is an offline host in the cluster when said host has actually already been removed. Signed-off-by: Adam King <[email protected]> (cherry picked from commit beea26f)
quincy: mgr/orchestrator: fix upgrade status help message Reviewed-by: Redouane Kachach <[email protected]>
quincy: cephadm: only pull host info from applied spec, don't try to parse yaml Reviewed-by: Redouane Kachach <[email protected]>
quincy: cephadm: don't overwrite cluster logrotate file Reviewed-by: Teoman ONAY <[email protected]>
quincy: mgr/cephadm: iscsi username and password defaults to admin Reviewed-by: Nizamudeen A <[email protected]>
quincy: cephadm: add `ip_nonlocal_bind` to haproxy deployment Reviewed-by: Redouane Kachach <[email protected]>
Signed-off-by: Adam King <[email protected]> (cherry picked from commit 7c6c715)
* drop the blank FS Menu when there is no FS * cleanup display_fs_menu() code Signed-off-by: Jos Collin <[email protected]> (cherry picked from commit a386400)
This commit intends to add: - sort-by field value feature to cephfs-top. - feature to limit number of clients displayed Fixes: https://tracker.ceph.com/issues/55121 Signed-off-by: Neeraj Pratap Singh <[email protected]> (cherry picked from commit 27cad62) Conflicts: src/tools/cephfs/top/cephfs-top:Removing the cherry-picked conflict (size=0) from line number 651 in this commit as it's position is changed as part of another PR.
Fixes: https://tracker.ceph.com/issues/55121 Signed-off-by: Neeraj Pratap Singh <[email protected]> (cherry picked from commit bc360a4)
Fixes: https://tracker.ceph.com/issues/58031 Signed-off-by: Neeraj Pratap Singh <[email protected]> (cherry picked from commit fd40f76)
Sorting is not working properly in case of change in the number of clients or after removing and creating the same filesystem again. Fixes: https://tracker.ceph.com/issues/58028 Signed-off-by: Neeraj Pratap Singh <[email protected]> (cherry picked from commit 2da139d) Conflicts: src/tools/cephfs/top/cephfs-top:Added argument `x_coord_map` in the function call for `create_client()` inside create_clients() method.
quincy: qa/suites/rbd: fix sporadic "rx-only direction" test failures Reviewed-by: Ramana Raja <[email protected]>
quincy: librbd: avoid EUCLEAN error after "rbd rm" is interrupted Reviewed-by: Ramana Raja <[email protected]>
quincy: ceph-crash: drop privleges to run as "ceph" user, rather than root (CVE-2022-3650)
quincy: common: notify all when max backlog reached in OutputDataSocket Reviewed-by: Laura Flores <[email protected]>
quincy: ceph.spec.in: disable system_pmdk on s390x for SUSE distros Reviewed-by: Ilya Dryomov <[email protected]>
quincy: make-dist: don't set Release tag in ceph.spec for SUSE distros Reviewed-by: Ernesto Puerta <[email protected]>
quincy: mgr/telemetry: add `basic_pool_options_bluestore` collection
Fixes: https://tracker.ceph.com/issues/57786 Signed-off-by: Adam King <[email protected]> (cherry picked from commit 9ee9c94)
Add definition for "period" to glossary. Signed-off-by: Zac Dover <[email protected]> (cherry picked from commit bd9bc3a)
…rt-50154-to-quincy quincy: doc/glossary: add "Period" to glossary
… 'tmpfs' When the device variable is rebound and become 'tmpfs', lsblk() shouldn't be called. Fixes: https://tracker.ceph.com/issues/58784 Signed-off-by: Guillaume Abrioux <[email protected]> (cherry picked from commit c0369fb)
quincy: ceph-volume/tests: add allowlist_externals to tox.ini
Replace "execute" with "run" in fourteen out of fifteen instances in multisite.rst. "Execute" is plain old too grand in most of these instances. Signed-off-by: Zac Dover <[email protected]> (cherry picked from commit b54b1b6)
…rt-50164-to-quincy quincy: doc/radosgw: s/execute/run/ in multisite.rst
When a snapshot sync is resumed and the get_replay_status function is called before handle_copy_image_progress, the syncing_percent value may be greater than 100 as the m_local_object_count is still set to zero. This commit sets the syncing_percent to 0 in such cases. Fixes: https://tracker.ceph.com/issues/58706 Signed-off-by: N Balachandran <[email protected]> (cherry picked from commit c7ae0f6)
Fixes: https://tracker.ceph.com/issues/58779 Signed-off-by: Radoslaw Zarzynski <[email protected]> (cherry picked from commit a235be2)
A monitor does support two kinds of addresses when binding msgr: 1) `bind_addrs` which are basically passed down the stack to e.g. the `bind()` syscall -- they are physical, low-level ones; 2) `public_addrs` which are exposed to peers over Ceph's on-wire protocols. This differentation is crucial for Rook and K8S use scenarios where, due to ephemeral nature of node's physical IPs, virtual _cluster IPs_ must be used instead for mon accesses. Although monitors still bind to physical ones, virtuals are exposed. Then, thankfully to NAT, the latter are converted to the former ones. Unfortunately, the current implmentation of this feature is based on the idea to 1) bind-as-usually and then 2) change-the-addrs via powerful `set_addrs()` setter. This setter is too powerful but the main issue is the `rebind()` sceario. It doesn't happen in monitors but OSDs may rebind when they get marked down by a monitor. Fixes: https://tracker.ceph.com/issues/58779 Signed-off-by: Radosław Zarzyński <[email protected]> (cherry picked from commit 1b24588)
Fixes: https://tracker.ceph.com/issues/58779 Signed-off-by: Radosław Zarzyński <[email protected]> (cherry picked from commit b207f9b)
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
github-actions
bot
added
needs-rebase
api-change
bluestore
build/ops
ceph-volume
cephadm
cephfs
Ceph File System
CI
Continuous Integration
common
core
crimson
dashboard
documentation
libcephsqlite
ceph SQLite3 VFS
mgr
mon
monitoring
nfs
orchestrator
pybind
rbd
rgw
rook
telemetry
tests
labels
May 15, 2024
I suspect this PR is unintentional. |
anthonyeleven
requested changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this was not intentional, as it isn't vaguely a valid PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
api-change
bluestore
build/ops
ceph-volume
cephadm
cephfs
Ceph File System
CI
Continuous Integration
common
core
crimson
dashboard
documentation
libcephsqlite
ceph SQLite3 VFS
mgr
mon
monitoring
needs-rebase
nfs
orchestrator
pybind
rbd
rgw
rook
telemetry
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
x
between the brackets:[x]
. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e