-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (downtime): SQL query fixed when adding recurring downtime #4161
Conversation
WalkthroughThe recent updates to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- centreon/www/class/centreonDowntime.class.php (2 hunks)
Additional comments not posted (3)
centreon/www/class/centreonDowntime.class.php (3)
726-726
: The updated return typeint|false
for theadd
method enhances type safety and is a good practice.
797-797
: The updated method signature foraddPeriod
improves type safety and clarity by explicitly defining parameter types.
815-847
: Using prepared statements in theaddPeriod
method enhances security by preventing SQL injection and improves performance by allowing the SQL execution plan to be cached.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- centreon/www/class/centreonDowntime.class.php (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- centreon/www/class/centreonDowntime.class.php
Description
SQL query fixed when adding recurring downtime
Type of change
Target serie
Checklist
Community contributors & Centreon team