Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(az-elasticpool): fix critical/warning threshold #4981

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

g-rei
Copy link

@g-rei g-rei commented Apr 4, 2024

Description

The storage mode of Azure's Elasticpool plugin (cloud::azure::database::elasticpool::plugin) did not take warning and critical thresholds in consideration. To correct this, I've adapted the code of another Azure's Plugin.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

You can simply test it by using this command :

perl centreon_plugins.pl --plugin=cloud::azure::database::elasticpool::plugin --custommode=api --mode=sessions
--resource='/subscriptions/xxx/resourceGroups/xxx/providers/Microsoft.Sql/servers/xxx/elasticpools/xxx'
--aggregation='average' --warning-storage-percent=70 --critical-storage-percent=90 --verbose

And then increase/decrease the values of warning-storage-percent or critical-storage-percent.

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

@g-rei g-rei requested a review from a team as a code owner April 4, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant