Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: saving blobs to s3 #190

Merged
merged 7 commits into from
Jun 3, 2024
Merged

Feature: saving blobs to s3 #190

merged 7 commits into from
Jun 3, 2024

Conversation

aopoltorzhicky
Copy link
Member

No description provided.

@aopoltorzhicky aopoltorzhicky added the feature New feature or request label May 6, 2024
@aopoltorzhicky aopoltorzhicky requested a review from vvuwei May 6, 2024 10:28
@aopoltorzhicky aopoltorzhicky self-assigned this May 6, 2024
vvuwei
vvuwei approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@vvuwei vvuwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few comments

internal/blob/storage_test.go Outdated Show resolved Hide resolved
internal/blob/r2.go Outdated Show resolved Hide resolved
@aopoltorzhicky aopoltorzhicky force-pushed the feature/store-blobs branch 2 times, most recently from 0d25a5f to 5fae1e6 Compare May 21, 2024 07:31
@aopoltorzhicky aopoltorzhicky merged commit 7f71895 into master Jun 3, 2024
6 checks passed
@aopoltorzhicky aopoltorzhicky deleted the feature/store-blobs branch June 3, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvuwei vvuwei vvuwei approved these changes

Assignees

@aopoltorzhicky aopoltorzhicky

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aopoltorzhicky @vvuwei