fix(proxy) - explanations #22348
Merged
fix(proxy) - explanations #22348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmiei
reviewed
May 1, 2024
ts/src/base/Exchange.ts
Outdated
| @@ -1043,6 +1043,10 @@ export default class Exchange { | |||
|
|
|||
| setProxyAgents (httpProxy, httpsProxy, socksProxy) { | |||
| let chosenAgent = undefined; | |||
| // in browser-side, proxy modules are not supported in 'fetch/ws' methods | |||
| if (!isNode && (httpProxy || httpsProxy || socksProxy)) { | |||
| throw new NotSupported (this.id + ' - proxies in browser-side projects are not supported. You have several choices: [A] Use `exchange.proxyUrl` property to redirect through local/remote cors-proxy snippet (find sample file named "sample-local-proxy-server-with-cors" in https://github.com/ccxt/ccxt/tree/master/examples/ folder, which includes sample for REST requests) [B] override `exchange.fetch` && `exchange.watch` methods to send request through your custom setup local/remote corst proxy server'); | |||
There was a problem hiding this comment.
property to redirect through local/remote cors-proxy snippet
this sentence does not make sense, what is snippet here? we should replace it with server or just remove it
There was a problem hiding this comment.
ah, it should have been 'server' not 'snippet'. edited
kroitor
pushed a commit
that referenced
this pull request
May 2, 2024
* fix(proxy) - explanation to users * minor * minor * Update Exchange.ts [ci skip]
DelAnt
pushed a commit
to DelAnt/ccxt
that referenced
this pull request
May 10, 2024
* fix(proxy) - explanation to users * minor * minor * Update Exchange.ts
DelAnt
pushed a commit
to DelAnt/ccxt
that referenced
this pull request
May 10, 2024
* fix(proxy) - explanation to users * minor * minor * Update Exchange.ts [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last comment fix #20686
Users should be aware that from browser-side JS, they can't use proxies (because proxy modules rely on 'net & http' native nodejs modules and there does not exist browser-side support for JS proxy functionality yet).