checksum handling unification #22150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carlosmiei in c# version it is not being transpiled, do you have some clues: |
|
Might be a bug with the ast-transpiler, does it make a difference if you add/remove a comment in the if clause? |
|
@carlosmiei wanted your thoughts here, is this too much abstraction (having two methods |
|
@carlosmiei PR ready |
ttodua
commented
May 1, 2024
| client.reject (err, messageHash); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
i have tried to have common prefix to these methods (OrderBookWhatever), instead of different prefixed like (throwOrderBook... RejectOrderBook)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
across exchanges/tests, we consistently see this nonce/checksum issues. also, it revealed that users were also claiming to be getting those issues. we should have some common unified way to handle them (either userland codes or either in tests too)
gate - https://app.travis-ci.com/github/ccxt/ccxt/builds/269961871#L3724
poloniex - https://app.travis-ci.com/github/ccxt/ccxt/builds/269961871#L3733
binance - https://app.travis-ci.com/github/ccxt/ccxt/builds/269961871#L3700
binanceusdm - https://app.travis-ci.com/github/ccxt/ccxt/builds/269969966#L3886
and also other exchanges have been throwing those issues.
Also,
checksumoption was unintuitive imo, and the new name is self-explanatory for users too.