Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rules for mgronline.com and pantip.com etc. #428

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mishari
Copy link

@mishari mishari commented Jan 28, 2024

No description provided.

@mishari mishari changed the title Added rules for mgronline.com and pantip.com Added rules for mgronline.com and pantip.com etc. Jan 29, 2024
@AUToelboell
Copy link
Collaborator

Rules with hardcoded actions are rejected. The rules should use the user's preference to select the action - in this case whether to accept or reject cookies for analytics and advertisement. Secondly bankokpost.com, matichon.co.th, mgronline.com are all supported under the bbc_fc rule. If you experience any issues, pls report them.

@mishari
Copy link
Author

mishari commented Feb 2, 2024

The bbc_fc rule doesn't seem to work on those site with their present state, should I modify the bbc_fc rule then?

Also what happens if the sites only have one button "accept and close" rather than giving options?

@AUToelboell
Copy link
Collaborator

Yes, modifying the bbc_fc rule is the way to go. The "Accept and Close" only option, is generally out of scope, because the user is only saved by a single click. And the importance of notifying the user is only getting access by selling their data is high.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants