fix(twitter): X support for Twitter #894
Conversation
ClaytonTDM
changed the title
|
Ah oops we made a PR at the same time lol, I think Twitter.com should be kept since Twitter control panel uses it. I guess I will close my PR since you where the first LGTM but the git diff is a little messy for some reason |
There was a problem hiding this comment.
Could this entire change not just be. All I can see here is copy and paste of the entire "twitter.com" code into a new "x.com" domain/
- @-moz-document domain("twitter.com")
+ @-moz-document domain("twitter.com"), domain("x.com")There was a problem hiding this comment.
sorry i dont know a lot abt css, i just found not having x support annoying and had to make a pr ;-;
| @@ -1028,6 +1780,143 @@ | |||
| } | |||
| } | |||
|
|
|||
| @-moz-document domain("x.com") { | |||
There was a problem hiding this comment.
Why select domain("x.com") twice when we already possess a instance of domain("x.com") once from above.
There was a problem hiding this comment.
because there was a second twitter.com
There was a problem hiding this comment.
Your right I missed that, there is one for light version too. I am sorry, but why is it this way anyway? Couldn't it be used twice? I made the PR really late and just assumed it was once in the code, I feel really dumb now that this has been merged
There was a problem hiding this comment.
Seems other themes don't do it that way, seems redundant :/
But I guess it could be considered cleaner, I feel like style guidelines should be made for stuff like this. I am not sure what everyone would prefer
There was a problem hiding this comment.
Fixed I am so sorry everyone #898
|
I can reopen my PR if everyone is cool with that, but I'd rather them get the credit to be honest:3 Eh whatever I'll just let everyone decide gn it's open again |
|
superseded by #895 |
馃敡 What does this fix? 馃敡
Adds support for x.com
馃棐 Checklist 馃棐
==UserStyle==header of thecatppuccin.user.cssfile.