Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement hex formatting support #172

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rubyowo
Copy link
Member

@rubyowo rubyowo commented Apr 3, 2024

Closes catppuccin/whiskers#8

I'd like to refactor this in the future or sometime else, it's a bit ugly currently.

@backwardspy backwardspy self-assigned this Apr 3, 2024
@backwardspy
Copy link
Member

just dropping an update on this; i've not forgotten about it but i haven't had the time so far to give it the review it deserves. i should be able to work on it in the coming days.

@sgoudham
Copy link
Contributor

Caught up with @backwardspy on discord, he still plans on coming back to this and would like to have an input in it 👍

@nullishamy
Copy link
Contributor

Speaking broadly, I'm not super into having loads of extra parameters everywhere. Can we somehow centralise this? Also not a fan of the String type being used here, I think at least a type alias to describe what the format represents would be a good improvement at, perhaps a struct that can handle the rendering too, let's see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add hex formatting options to frontmatter
4 participants