Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: integrate whiskers #15

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

nullishamy
Copy link

Also restructures the themes to be more organised / sensibly named.

@nullishamy nullishamy changed the title build: start whiskers integration build: integrate whiskers Apr 1, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgive me for my ignorance but what is this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a second variant that was present in the original - https://github.com/catppuccin/chrome/blob/main/src/Chrome-catppuccin-frappe/Google-Store/manifest.json#L3 see here for an example. It has different colours and has no accent.

Doing this all in one file was annoying and cluttered.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh what is that needed for? Might have been a mistake?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure? Want to keep 1:1 where possible though, and it's not much more effort to maintain (and this port does not see a lot of updates anyways..)

chrome.tera Outdated Show resolved Hide resolved
chrome.tera Outdated Show resolved Hide resolved
chrome.tera Show resolved Hide resolved
Comment on lines +16 to +17
"name": "Catppuccin Chrome Theme - {{ flavor.identifier | capitalize }} {{ accent | capitalize }}",
"description": "Soothing pastel theme for Google Chrome - Catppuccin {{ flavor.identifier | capitalize }}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "Catppuccin Chrome Theme - {{ flavor.identifier | capitalize }} {{ accent | capitalize }}",
"description": "Soothing pastel theme for Google Chrome - Catppuccin {{ flavor.identifier | capitalize }}",
"name": "Catppuccin Chrome Theme - {{ flavor.name }} {{ accent | capitalize }}",
"description": "Soothing pastel theme for Google Chrome - Catppuccin {{ flavor.name }}",

Same with the Google Store one if we are keeping that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had kept it this way to avoid the accent on Frappe, don't want to run the risk of breaking things.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Chrome fully supports Unicode? Would be very surprised if they didn't lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants