Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally had this MR to fix the build for Mac M1. #2160 .
After testing this in my environment, I realised that with the current implementation:
../../libs/model_interface
to allow bindgen to generate the necessary rust bindings. I managed to publish the crate here.Note that for now in build.rs I check for apple + aarch64 before downloading the dylib, as that's the machine I have. I don't have a non-M1 mac to test if that works fine.
Would like to get feedback on whether this is a reasonable approach, and can be merged into master.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en.