fix: NaN mode max model export to code catboost#2104 #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evgueni-Petrov-aka-espetrov
requested changes
May 31, 2022
catboost/libs/model/model_export/resources/apply_catboost_nan_max_model.cpp
Outdated
Show resolved
Hide resolved
Evgueni-Petrov-aka-espetrov
approved these changes
Jul 25, 2022
|
@arcadia-devtools Ship it! |
|
CLA already signed |
|
@Evgueni-Petrov-aka-espetrov, internal review request created: 2769533 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #2104 where NaN mode Max models are incorrectly exported to Python and C++ code.
The problem is line 42 of catboost/catboost/libs/model/model_export/resources/apply_catboost_model.py:
where if
float_features[model.float_features_index[i]]is NaN, any comparison to a border will be false and therefore less than all borders. This is the opposite behavior of what NaN mode Max requires.I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en