Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reproduction Results for Anserini Repo Steps #2494

Merged
merged 4 commits into from
May 12, 2024

Conversation

hrouzegar
Copy link
Contributor

Environment Details:
-Operating System: Ubuntu 22.04.4 LTS
-Java Version: Upgraded to JDK 21 from JDK 11 to resolve compatibility issues that were initially causing build failures.

Experience:
The process followed the outlined steps without significant issues, except for an initial JDK version mismatch. Once the JDK was updated to version 21, all scripts executed flawlessly, and the expected results were successfully reproduced. The step-by-step guidance provided was clear and easy to follow.

Suggestions for Improvement:
Considering the JDK version mismatch issue I encountered, it could be beneficial to include a specific note about verifying JDK version requirements in the setup documentation, similar to the approach taken in the Pyserini documentation.

@lintool
Copy link
Member

lintool commented May 11, 2024

Environment Details: -Operating System: Ubuntu 22.04.4 LTS -Java Version: Upgraded to JDK 21 from JDK 11 to resolve compatibility issues that were initially causing build failures.

Experience: The process followed the outlined steps without significant issues, except for an initial JDK version mismatch. Once the JDK was updated to version 21, all scripts executed flawlessly, and the expected results were successfully reproduced. The step-by-step guidance provided was clear and easy to follow.

Suggestions for Improvement: Considering the JDK version mismatch issue I encountered, it could be beneficial to include a specific note about verifying JDK version requirements in the setup documentation, similar to the approach taken in the Pyserini documentation.

Where in the documentation should we clarify?

We already have these in the README:

Screen Shot 2024-05-11 at 7 15 58 AM Screen Shot 2024-05-11 at 7 16 08 AM

Where else would you suggest we update the docs?

@lintool lintool self-requested a review May 11, 2024 11:17
Copy link
Member

@lintool lintool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix conflicts, sort orders chronologically.

@lintool lintool merged commit d854dcb into castorini:master May 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants