Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Java versions #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Test Java versions #13

wants to merge 1 commit into from

Conversation

ajnelson-nist
Copy link
Member

No description provided.

Signed-off-by: Alex Nelson <[email protected]>
@ajnelson-nist ajnelson-nist mentioned this pull request Jun 2, 2023
@ajnelson-nist
Copy link
Member Author

Ah, dear. I suppose this PR would also need to account for these lines of pom.xml:

  <properties>
    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    <maven.compiler.source>18</maven.compiler.source>
    <maven.compiler.target>18</maven.compiler.target>
    <exec.mainClass>org.caseontology.examples.CASE2Geo</exec.mainClass>
  </properties>

I'm fine with pom.xml somehow pulling that from the environment, or this PR being NACKed.

@kchason
Copy link
Member

kchason commented Jun 2, 2023

There was a reason we needed Java 18 for one of the parts of this application. I can look into if we can downgrade it to support Java 11 and what the impacts would be. I would say, let's leave this open, but changes will be needed prior to merging.

@ajnelson-nist
Copy link
Member Author

I don't think we need to force a downgrade. Could you highlight the >=18 requirement code with an inlined comment?

And meanwhile, I might just close this PR anyway if there's an issue with hard-coding the Java version in XML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants