-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TagOverflow): overflow tooltip variants #5249
feat(TagOverflow): overflow tooltip variants #5249
Conversation
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good! just a few comments
packages/ibm-products/src/components/TagOverflow/TagOverflowModal.js
Outdated
Show resolved
Hide resolved
packages/ibm-products/src/components/TagOverflow/TagOverflowPopover.js
Outdated
Show resolved
Hide resolved
additionally, this isn't specifically related to the PR, but i wanted to make a note of this. the
i didn't see |
Thanks for suggesting this optimisation. I have updated the code. |
022f8ff
Closes #4090
Support overflow content variants. Variants are "read-only tags" and "interactive tags."
What did you change?
How did you test and verify your work?
Storybook