refactor(EditTearsheetForm): add Typescript types #5167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgnacioBecerra
requested review from
matthewgallo and
amal-k-joy
and removed request for
a team
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/ibm-products/src/components/EditTearsheet/EditTearsheetForm.tsx
Outdated
Show resolved
Hide resolved
packages/ibm-products/src/components/EditTearsheet/EditTearsheetForm.tsx
Outdated
Show resolved
Hide resolved
amal-k-joy
requested changes
Jun 4, 2024
| @@ -19,7 +19,7 @@ const blockClass = `${pkg.prefix}--tearsheet-edit`; | |||
| // This is a general context for the forms container | |||
| // containing information about the state of the container | |||
| // and providing some callback methods for forms to use | |||
| export const FormContext = createContext(null); | |||
| export const FormContext = (createContext < FormContext) | (null > null); | |||
There was a problem hiding this comment.
Hey,
Can you help me to know the syntax used here? By any chance did you mean to use as below:
export const FormContext = createContext<FormContextType | null>(null);
There was a problem hiding this comment.
Hey Amal, you're right, but I'd like to export the FormContextType from EditTearsheet.tsx, which will be introduced in #5082, wondering if we can get that in first?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4283
This PR introduces Typescript types to EditTearsheetForm
What did you change?
Changed the file and component to using Typescript
How did you test and verify your work?
Ran tests and build locally