Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include variants and content for tag overflow tooltips #4090

Closed
4 of 6 tasks
Tracked by #4085
elycheea opened this issue Jan 19, 2024 · 1 comment · Fixed by #5249
Closed
4 of 6 tasks
Tracked by #4085

Include variants and content for tag overflow tooltips #4090

elycheea opened this issue Jan 19, 2024 · 1 comment · Fixed by #5249
Assignees
@szinta
Labels
component: TagSet role: dev

Comments

@elycheea
Copy link
Contributor

elycheea commented Jan 19, 2024 •
edited by szinta

The tooltip of the tag overflow should display content from the item labels.

There are two variants for this — “read-only tags” and “interactive”/filterable tags.

Design notes

  • When rendering read-only text, content should wrap if it does not fit the toggletip width (288px)
  • When rendering tag, content should truncate if the whole tag does not fit the toggletip width

Development notes

Relevant props from original TagSet.

  • overflowAlign
  • overflowType
  • showAllTagsLabel
  • overflowClassName

Acceptance criteria
Beta Give feedback
@elycheea elycheea mentioned this issue Jan 19, 2024
Open
4 tasks
@elycheea elycheea changed the title Add support for tooltip behaviors Include variants and content for tag overflow tooltips Jan 19, 2024
@szinta szinta self-assigned this Apr 22, 2024
@szinta
Copy link
Contributor

szinta commented Apr 25, 2024

As per design notes,

When using a tag overflow for other items, text should be used in the toggletip to display the remaining items. Using text in the toggletip ensures the content is accessible.

So I assume we should support interactive/filterable overflow tags only for filterable Tag items. Please confirm?

@szinta szinta mentioned this issue May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szinta szinta

Labels
component: TagSet role: dev
Projects
Carbon for IBM Products
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(TagOverflow): overflow tooltip variants szinta/ibm-products
2 participants
@elycheea @szinta