fix(16150): fixes Structured List icons's column as per spec #16393
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/styles/scss/components/structured-list/_structured-list.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Added a couple comments, we want to make sure we are changing the component, not adding to the story in Storybook as the consumer won't get those updates.
I also wanted to make sure you were looking at the correct component when making these changes. The issue seems to be referring to the feature flag version of Structured list. I would confirm with design before making updates to the original component.
I requested @Kritvi-bhatia17 as a reviewer also, we want to be sure whenever there are visual changes that a designer signs off.
packages/react/src/components/StructuredList/StructuredList.tsx
Outdated
Show resolved
Hide resolved
packages/styles/scss/components/structured-list/_structured-list.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks @alisonjoseph for tagging me!
Looks good to me @2nikhiltom (from the design perspective) 🔥
alisonjoseph
added
status: one more review 👀
and removed
status: ready for review 👀
status: visual review 🔍
labels
9dff06c
Closes #16150
The padding between the icon, whether it's a checkmark or radio button, and the text will be 16px.
Size of column with icon will be 32px (16px icon + 16px padding)
Changelog
New
Styles updated
Testing / Reviewing
Open Storybook and navigate to the StructuredList component.
Go to Selectable. Verify padding and column size.