Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RadioTile): update RadioTile to accept Slug, phase 3 updates #16227

Merged

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Apr 18, 2024

Closes #16224

Adds in AI styles for RadioTile

Changelog

New

  • Adds in support for slug prop to RadioTile

Changed

  • Updated the unstable__slug --> Examples --> Tile story to include 3 RadioTile, 3 RadioTile with feature flags enabled, and updated the SelectableTile to show 3.
  • Fixed some z-index issues with RadioTile and SelectableTIle when the AI slug is clicked

Testing / Reviewing

Ensure the unstable__slug --> Examples --> Tile story looks correct and the styles are applied properly

@tw15egan tw15egan changed the title feat(RadioTile): update RadioTile to accept Slug, phase 3 updates feat(RadioTile): update RadioTile to accept Slug, phase 3 updates Apr 18, 2024
Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 02122d7
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/662168106591d200087d0407
😎 Deploy Preview https://deploy-preview-16227--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 9a730c3
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6650dca5b175250008b6eb00
😎 Deploy Preview https://deploy-preview-16227--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good but in the feature flag verison the unselected tiles are supposed to always have the unchecked radio button. Like so:

image

@tw15egan
Copy link
Member Author

@aagonzales fixed 👍🏻

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK that looks good but I just noticed another thing. The focus on the radio tiles (both kinds) should be a 2px border. Its showing at 1px right now
image

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Just one question

packages/react/src/components/Slug/slug-story.scss Outdated Show resolved Hide resolved
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good now! RIP TJ

@guidari guidari requested a review from a team as a code owner May 24, 2024 12:29
@guidari guidari requested a review from tay1orjones May 24, 2024 12:29
Copy link

netlify bot commented May 24, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 9a730c3
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6650dca5afbd210008f95ec0
😎 Deploy Preview https://deploy-preview-16227--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@guidari guidari added this pull request to the merge queue May 24, 2024
Merged via the queue into carbon-design-system:main with commit f7065bc May 24, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI enhancements: Add AI variant for radio selection tile
5 participants