Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps-dev): upgrade @carbon/icons 11.37 -> 11.41 #183

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented May 12, 2024

SquareSolid seems to be missing descriptor.content (for example, expecting a path or rect element).

As a result, this seems to produce an "empty" SVG. This is likely unintended and a potential corruption in the build step because the source SVG file also resembles the following:

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"/>

Meanwhile, the original asset in the PR contains rect elements:

<?xml version="1.0" encoding="UTF-8"?>
<svg id="icon" xmlns="http://www.w3.org/2000/svg" width="32" height="32" viewBox="0 0 32 32">
  <defs>
    <style>
      .cls-1 {
        fill: none;
      }
      .cls-1, .cls-2 {
        stroke-width: 0px;
      }
    </style>
  </defs>
  <rect class="cls-2" x="4" y="4" width="24" height="24" rx="2" ry="2"/>
  <rect id="_Transparent_Rectangle_" data-name="&amp;lt;Transparent Rectangle&amp;gt;" class="cls-1" width="32" height="32" transform="translate(0 32) rotate(-90)"/>
</svg>

@metonym metonym marked this pull request as ready for review May 27, 2024 16:15
@metonym
Copy link
Collaborator Author

metonym commented May 27, 2024

The bug hasn't been confirmed upstream; going to merge for now to not fall behind. The icon can always be patched in a future release.

@metonym metonym merged commit 997f3d0 into master May 27, 2024
3 checks passed
@metonym metonym deleted the upgrade-11.41 branch May 27, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant