Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: drop support for ES, UMD formats #991

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Jan 10, 2022

Fixes #896, fixes #1427

This PR drops support for the compiled ES, UMD formats. Instead, only the uncompiled Svelte source code will be shipped.

This should have no impact for users of Vite/SvelteKit/Webpack/Rollup. This solves issues for set-ups that experience errors using the compiled code (#896). A bonus is that the carbon-components-svelte package will be considerably lighter in size.

@dummdidumm
Copy link

dummdidumm commented Jan 14, 2022

FYI there's a feature request in SvelteKit which would enable also bundling to ESM/UMD: sveltejs/kit#2572 . There are valid cases where you would want people to be able to use your library standalone. If that's the case for carbon-components-svelte is another question.
An alternative (still a breaking change) would be to add the compiled versions, but within special sub folders, so you would do something like import { ... } from 'carbon-components-svelte/umd'. This is likely also the way this gets implemented in SvelteKit.

@metonym
Copy link
Collaborator Author

metonym commented Jan 14, 2022

@dummdidumm Thank you for the info! Good to know that there are potential use cases for the bundled code.

@metonym metonym changed the title Only ship uncompiled Svelte source code, drop support for ESM, UMD formats breaking: drop support for ESM, UMD formats Aug 25, 2022
@metonym metonym changed the title breaking: drop support for ESM, UMD formats breaking: drop support for ES, UMD formats Aug 25, 2022
@metonym metonym marked this pull request as ready for review August 27, 2022 18:29
@metonym metonym force-pushed the master branch 2 times, most recently from e7485c4 to 417102d Compare November 8, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants