Tweaks to DataTable generics #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make key in `cell` slot prop less strict to prevent type errors in markup. - Resolve property path names up to one level deep for header keys.
|
The nested keys are great. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjustments for #1954.
cellslot prop less strict to prevent type errors in markup.Type errors are hard to deal with in Svelte 3/4, this could be reverted again in Svelte 5.
idfrom possible keys.Limited to one level for now as combinatorial explosion can make type resolution quite heavy.
For deeper levels a custom helper function could be used or, as with synthetic keys,
as anycan be used to ignore the type error.I added some line breaks for readability in the source, these seem to be added to the
COMPONENT_API.jsonbut the docs are not visibly affected.The types in
DataTableTypes.d.tsare currently not directly accessible via the docs. (Also, the name and location of that file is debatable. The types are not really specific to this component and could potentially become useful elsewhere.)