Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(checkbox): forward focus, blur events to Checkbox and InlineCheckbox #1937

Merged
merged 5 commits into from
Mar 16, 2024
Merged

fix(checkbox): forward focus, blur events to Checkbox and InlineCheckbox #1937

merged 5 commits into from
Mar 16, 2024

Conversation

wickning1
Copy link
Contributor

No description provided.

brunnerh
brunnerh reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@brunnerh brunnerh left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Docs need to be rebuilt so the events are added to the Forwarded events lists.
  • Order of focus and blur should ideally be consistent, though I don't think it matters.

@wickning1
Copy link
Contributor Author

Done.

@metonym metonym changed the title forward on:focus and on:blur from Checkbox and InlineCheckbox fix(checkbox): forward focus, blur events to Checkbox and InlineCheckbox Mar 16, 2024
@metonym metonym merged commit 6364b23 into carbon-design-system:master Mar 16, 2024
1 check passed
@metonym
Copy link
Collaborator

metonym commented Mar 16, 2024

Released in v0.84.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunnerh brunnerh brunnerh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wickning1 @metonym @brunnerh