Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the laravel sample application #472

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

imonroe
Copy link

@imonroe imonroe commented Aug 4, 2019

What I changed:

  • in the Dockerfile, it called for mysql-client, but the new php-7.2 image needs that to be changed to mariadb-client. See: https://stackoverflow.com/questions/57048428/e-package-mysql-client-has-no-installation-candidate-in-php-fpm-image-build-u
  • in the ./configuration/nginx/conf.d/app.conf file, there is a note that the fastcgi_pass variable needs to be changed to reflect the name of the container. I changed it to project_laravel to ensure it would come up correctly.
  • in the docker-compose.yml file, the context to build the app image was listed as ./laravel-app, but that's not where the dockerfile lives. Changed it to just ., which fixes the build.
    I then re-tarred the file and replaced the one in the repo.

@githubsaturn
Copy link
Collaborator

Thanks @imonroe !

I have to park this PR for a few days until I find a new home for sample apps. The current way of bundling them with the main repo has made the repo way too bloated. I'll split them out and will let you know the new format.

@imonroe
Copy link
Author

imonroe commented Aug 5, 2019

No problem. I was tempted to exclude the vendor directory to reduce the size of the tar, but I figured if it was there, it was probably for a good reason.

@sleeyax
Copy link

sleeyax commented May 7, 2020

Sooooooo is this PR ever gonna get merged?

@githubsaturn
Copy link
Collaborator

TLDR:
No. I just kept the PR open for people who are interested. You can download the tar from the source of the PR: https://github.com/imonroe/caprover/blob/fix-laravel/captain-sample-apps/laravel.tar

The tar file is too large to be merged into the main repo. I was planning on creating a separate repo for sample apps, but I haven't gotten to it yet. Alternatively, some people started hosting their own sample repos and added them to the Community Apps Section. Feel free to do that.

@imonroe
Copy link
Author

imonroe commented May 7, 2020

I likely should update my fork to update PHP to 7.3 and Laravel to 7.x I'll see if I can do that this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants