Fixed the laravel sample application #472
Open
+0
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I changed:
mysql-client
, but the new php-7.2 image needs that to be changed tomariadb-client
. See: https://stackoverflow.com/questions/57048428/e-package-mysql-client-has-no-installation-candidate-in-php-fpm-image-build-u./configuration/nginx/conf.d/app.conf
file, there is a note that thefastcgi_pass
variable needs to be changed to reflect the name of the container. I changed it toproject_laravel
to ensure it would come up correctly.docker-compose.yml
file, the context to build the app image was listed as./laravel-app
, but that's not where the dockerfile lives. Changed it to just.
, which fixes the build.I then re-tarred the file and replaced the one in the repo.