Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skiplink example docs to match new branding #5091

Merged
merged 2 commits into from
May 21, 2024

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented May 16, 2024

Done

  • Updates the logo used in the skip-link example to the new CoF logo.
  • Updates the skip-link nav example to follow new default nav layout.

Fixes WD-11267

QA

  • Open demo
  • Verify that the navigation on the skip-link component matches the updated branding. Compare it to the navigation pattern.
  • Verify that the skip-link functionality still works (appears on keyboard focus, & skips to main content on activation)

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

Before:
image

After:
image

@jmuzina jmuzina added Review: Design needed Review: QA needed Review: Code needed Documentation 馃摑 Documentation changes or updates Review: A11y needed Review: Percy needed This PR needs a review of Percy for visual regressions labels May 16, 2024
@jmuzina jmuzina self-assigned this May 16, 2024
@webteam-app
Copy link

@jmuzina jmuzina marked this pull request as ready for review May 16, 2024 19:35
Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bartaz bartaz merged commit 5d4572c into canonical:main May 21, 2024
5 checks passed
@jmuzina jmuzina deleted the update-skiplink-docs branch June 5, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants