Add mocha test to check validity of all external links #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Darn, i was just about to review this today |
|
I was wondering who'd show up first, you or Joe 😂 cleaning out old PR's from my list! |
|
Sorry had allot of my plate for 4 years, lots of PRs to review. |
|
I see how it is, new priorities and all that :( |
|
|
|
2017, when I still had had hope that one of you would review and merge this PR
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a package.json with some relevant information to enable us to run it as a normal node project on travis later on. I've added a couple libraries including mocha and should, and I've created a test for all external links. The original proposed library had to be ditched as it would try to check relative and anchor links which isn't so helpful right now.
I've also just added a
.travis.ymlfile, if we enable builds on "Branch Updates" and "Pull Requests" then it'll build all PR pushes once plus merges into master as we want.The tests are quite quick right now so I suggest we include them in the PR process for now.
Notes:
This implements #12, cc @PandelisZ & @joenash