Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow requests with adhoc RequestEditor #69

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

calvinmclean
Copy link
Owner

  • Add new Client methods with suffix "WithEditor" that accept a RequestEditor argument instead of using the client's editor

Closes #17

- Add new Client methods with suffix "WithEditor" that accept a
  RequestEditor argument instead of using the Client's editor

Closes #17
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 93.47826% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.22%. Comparing base (402cb2b) to head (f417048).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   81.57%   81.22%   -0.36%     
==========================================
  Files          22       22              
  Lines        1444     1465      +21     
==========================================
+ Hits         1178     1190      +12     
- Misses        172      181       +9     
  Partials       94       94              

@calvinmclean calvinmclean force-pushed the feature/17/per-request-editor branch from b5091c9 to f417048 Compare June 27, 2024 04:45
@calvinmclean calvinmclean merged commit 5a5cd5e into main Jun 27, 2024
5 checks passed
@calvinmclean calvinmclean deleted the feature/17/per-request-editor branch June 27, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client should be able to set a RequestEditor per-request or otherwise modify requests before sending
1 participant