fix: error when unlinking google account #15011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
github-actions
bot
added
authentication
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Current Playwright Test Results Summary✅ 321 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/14/2024 01:45:24pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 209b721 Started: 05/14/2024 01:40:59pm UTC
|
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Paid booking should be able to be rescheduled
Retry 1 • Initial Attempt |
2.95% (7)7 / 237 runsfailed over last 7 days |
12.66% (30)30 / 237 runsflaked over last 7 days |
|
Stripe integration Paid booking should be able to be cancelled
Retry 1 • Initial Attempt |
2.97% (7)7 / 236 runsfailed over last 7 days |
10.17% (24)24 / 236 runsflaked over last 7 days |
|
Stripe integration When event is paid and confirmed Payment should confirm pending payment booking
Retry 1 • Initial Attempt |
2.56% (6)6 / 234 runsfailed over last 7 days |
5.13% (12)12 / 234 runsflaked over last 7 days |
|
Stripe integration When event is paid and confirmed Paid and confirmed booking should be able to be rescheduled
Retry 1 • Initial Attempt |
2.15% (5)5 / 233 runsfailed over last 7 days |
4.72% (11)11 / 233 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- legacy user can add multiple organizer address
Retry 1 • Initial Attempt |
0.38% (1)1 / 260 runfailed over last 7 days |
5.77% (15)15 / 260 runsflaked over last 7 days |
📄 apps/web/playwright/manage-booking-questions.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Manage Booking Questions For User EventType Do a booking with Checkbox type question and verify a few thing in b/w
Retry 1 • Initial Attempt |
0.38% (1)1 / 262 runfailed over last 7 days |
3.82% (10)10 / 262 runsflaked over last 7 days |
📄 apps/web/playwright/reschedule.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Reschedule Tests Attendee should be able to reschedule a booking
Retry 1 • Initial Attempt |
0% (0)0 / 291 runsfailed over last 7 days |
0.69% (2)2 / 291 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
MEETING_ENDED, MEETING_STARTED should create/remove scheduledWebhookTriggers for existing bookings
Retry 2 • Retry 1 • Initial Attempt |
4.17% (3)3 / 72 runsfailed over last 7 days |
41.67% (30)30 / 72 runsflaked over last 7 days |
📄 apps/web/playwright/teams.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 1 • Initial Attempt |
2.26% (6)6 / 266 runsfailed over last 7 days |
21.05% (56)56 / 266 runsflaked over last 7 days |
📄 apps/web/playwright/managedBooking/advancedOptions.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Check advanced options in a managed team event type Check advanced options in a managed team event type without offer seats
Retry 1 • Initial Attempt |
0% (0)0 / 260 runsfailed over last 7 days |
50% (130)130 / 260 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Namespacing Inline Embed Add inline embed using a namespace without reload
Retry 1 • Initial Attempt |
0.39% (1)1 / 259 runfailed over last 7 days |
56.76% (147)147 / 259 runsflaked over last 7 days |
|
Namespacing Different namespaces can have different init configs
Retry 1 • Initial Attempt |
0% (0)0 / 258 runsfailed over last 7 days |
57.36% (148)148 / 258 runsflaked over last 7 days |
|
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1 • Initial Attempt |
0% (0)0 / 259 runsfailed over last 7 days |
59.46% (154)154 / 259 runsflaked over last 7 days |
|
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace
Retry 1 • Initial Attempt |
0.77% (2)2 / 259 runsfailed over last 7 days |
57.14% (148)148 / 259 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 1 • Initial Attempt |
38.70% (113)113 / 292 runsfailed over last 7 days |
33.90% (99)99 / 292 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- legacy login flow user & logout using dashboard
Retry 1 • Initial Attempt |
0% (0)0 / 260 runsfailed over last 7 days |
18.46% (48)48 / 260 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 9 Flakes
Top 1 Common Error Messages
|
|
9 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
1.15% (3)3 / 261 runsfailed over last 7 days |
55.56% (145)145 / 261 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-128.32% (-145)-145 / 113 runsfailed over last 7 days |
128.32% (145)145 / 113 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-126.55% (-143)-143 / 113 runsfailed over last 7 days |
126.55% (143)143 / 113 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-123.89% (-140)-140 / 113 runsfailed over last 7 days |
124.78% (141)141 / 113 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-125.89% (-141)-141 / 112 runsfailed over last 7 days |
125.89% (141)141 / 112 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-125.89% (-141)-141 / 112 runsfailed over last 7 days |
125.89% (141)141 / 112 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-125.89% (-141)-141 / 112 runsfailed over last 7 days |
125.89% (141)141 / 112 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-125.89% (-141)-141 / 112 runsfailed over last 7 days |
125.89% (141)141 / 112 runsflaked over last 7 days |
|
Popup Tests should open on clicking child element
Retry 1 • Initial Attempt |
-122.52% (-136)-136 / 111 runsfailed over last 7 days |
122.52% (136)136 / 111 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Email not matching orgAutoAcceptEmail nonexisting user invited to a Team inside organization
Retry 1 • Initial Attempt |
0.38% (1)1 / 261 runfailed over last 7 days |
4.98% (13)13 / 261 runsflaked over last 7 days |
|
Organization Email matching orgAutoAcceptEmail and a Verified Organization with DNS Setup Done nonexisting user is invited to a team inside organization
Retry 1 • Initial Attempt |
0% (0)0 / 257 runsfailed over last 7 days |
7% (18)18 / 257 runsflaked over last 7 days |
📄 apps/web/playwright/team/team-invitation.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Team Invitation (non verified)
Retry 1 • Initial Attempt |
4.07% (11)11 / 270 runsfailed over last 7 days |
6.67% (18)18 / 270 runsflaked over last 7 days |
|
Team Invitation (verified)
Retry 1 • Initial Attempt |
1.85% (5)5 / 270 runsfailed over last 7 days |
8.52% (23)23 / 270 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Router URL should work
Retry 1 • Initial Attempt |
0.38% (1)1 / 260 runfailed over last 7 days |
16.54% (43)43 / 260 runsflaked over last 7 days |
zomars
commented
May 13, 2024
| @@ -439,10 +448,7 @@ const ProfileView = () => { | |||
| <Button | |||
| color="primary" | |||
| onClick={() => { | |||
| updateProfileMutation.mutate({ | |||
There was a problem hiding this comment.
It didn't make much sense to have this being part of updateProfile. updateProfile is doing too much already.
There was a problem hiding this comment.
Added simple unit/integration test
| @@ -74,9 +73,6 @@ export const updateProfileHandler = async ({ ctx, input }: UpdateProfileOptions) | |||
| const secondaryEmails = input?.secondaryEmails || []; | |||
| delete input.secondaryEmails; | |||
|
|
|||
| const unlinkConnectedAccount = input?.unlinkConnectedAccount || false; | |||
| delete input.unlinkConnectedAccount; | |||
There was a problem hiding this comment.
TBH. This feels like a hack. Separated to new handler.
There was a problem hiding this comment.
Single purpose handler in here
Udit-takkar
approved these changes
May 14, 2024
zomars
deleted the
zomars/cal-3519-error-when-trying-to-unlink-a-google-account
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix-account-unlink.mov
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
yarn test unlinkConnectedAccount