Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no rating submitted text fixed #15007

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smitgol
Copy link

@smitgol smitgol commented May 13, 2024

What does this PR do?

Before
image

After:
no_rating_fixes

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

Copy link

vercel bot commented May 13, 2024

@smitgol is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label May 13, 2024
@graphite-app graphite-app bot requested a review from a team May 13, 2024 17:13
@github-actions github-actions bot added insights area: insights, analytics Low priority Created by Linear-GitHub Sync labels May 13, 2024
Copy link
Contributor

github-actions bot commented May 13, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added the ui area: UI, frontend, button, form, input label May 13, 2024
@dosubot dosubot bot added the 🐛 bug Something isn't working label May 13, 2024
Copy link

graphite-app bot commented May 13, 2024

Graphite Automations

"Add community label" took an action on this PR • (05/13/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/13/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@Udit-takkar Udit-takkar changed the title no rating submitted text fixed fix: no rating submitted text fixed May 13, 2024
"text-semibold font-cal text-emphasis text-center text-xl",
icon && "mt-6"
)}>
<h2 className={classNames("text-emphasis text-center text-xl font-bold", icon && "mt-6")}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove the font?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

font-cal was causing spacing between letters.I tried to reduce letter but was not working so i removed that font

@keithwillcode keithwillcode added this to the v4.2 milestone May 15, 2024
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync insights area: insights, analytics Low priority Created by Linear-GitHub Sync Stale ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-3660] UI: Text spacing on insights ratings section is whacky
3 participants