chore: open disableGuests for event-types apiv2 #15001
Conversation
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (05/13/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add platform team as reviewer" took an action on this PR • (05/13/24)1 reviewer was added to this PR based on Keith Williams's automation. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
keithwillcode
added
core
dosubot
bot
added
api
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 77 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/14/2024 10:49:11am UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 5a1407a Started: 05/14/2024 10:46:25am UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 2 • Retry 1 • Initial Attempt |
2.32% (6)6 / 259 runsfailed over last 7 days |
20.46% (53)53 / 259 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can update a users email (verification enabled)
Retry 2 • Retry 1 • Initial Attempt |
38.25% (109)109 / 285 runsfailed over last 7 days |
34.39% (98)98 / 285 runsflaked over last 7 days |
| @@ -131,6 +131,7 @@ describe("Event types Endpoints", () => { | |||
| description: "A description of the test event type.", | |||
| length: 60, | |||
| hidden: false, | |||
| disableGuests: true, | |||
There was a problem hiding this comment.
Maybe we can have a separate "it" for disablingGuests event type "it should create an event type with guests disabled" and then using fixture delete it? It's just so that we don't put all event type test cases into 1 test, and if there are other event type cases create a separate test for each.
There was a problem hiding this comment.
I think we need to create tests cases only to test different logics, for something so trival as updating root fields I think less is more
…cal.com into chore-event-types-disable-guests
What does this PR do?
Api v2 event-types can disable guests